Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 37 function renaming #81

Merged
merged 10 commits into from
Aug 8, 2024
Merged

Issue 37 function renaming #81

merged 10 commits into from
Aug 8, 2024

Conversation

ThomUK
Copy link
Collaborator

@ThomUK ThomUK commented Aug 7, 2024

closes #37

Renames the core 6 functions to calc_*, including average_wait being renamed target_mean_wait, better describing what it does.

@ThomUK ThomUK requested review from matt-dray and Lextuga007 August 7, 2024 21:41
Copy link
Collaborator

@matt-dray matt-dray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I did a 'find in files' search for each of the functions names sans calc_ (as well as average_wait) to see if anything was missed. I think you got them all.

@ThomUK
Copy link
Collaborator Author

ThomUK commented Aug 8, 2024

Excellent, thank you!

@ThomUK ThomUK merged commit faa0bef into main Aug 8, 2024
8 checks passed
@ThomUK ThomUK deleted the issue_37_function_renaming branch August 8, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

average_wait() function has ambiguous name
2 participants